search

ntrepid8 / ex_crypto

Wrapper around the Erlang crypto module for Elixir.
MIT License
144 stars 48 forks source link

Replace Poison with Jason #32

Open ybod opened 5 years ago

ybod commented 5 years ago
  1. Replace Poison with Jason for JSON encoding/decoding
  2. Update hex_doc version
  3. Format code with mix format
ntrepid8 commented 5 years ago

What is the motivation for using Jason rather than Poison?

ybod commented 5 years ago

Jason is faster and "smaller", many projects already switched to Jason.

cgorshing commented 4 years ago

I came here to request these changes as well. As Phoenix comes with Jason already as a dependency, many projects are following suite to keep from bringing in dependencies that do the same thing.

If you don't want to use a json library directly, then maybe we could tie it to a behaviour or something like https://github.com/scrogson/oauth2/#configure-a-serializer

Another example of people asking for this https://github.com/parroty/extwitter/issues/121

ntrepid8 commented 4 years ago

I'm not opposed to using Jason :)

Mostly I need to figure out why Travis isn't running the CI jobs anymore :(

barttenbrinke commented 3 years ago

Can somebody merge this? Oh, I see Poison has a new maintainer now 🤔