search

ntrteam / flashcart_core

A hopefully reusable component for dealing with flashcart specific behavior.
GNU General Public License v3.0
126 stars 32 forks source link

add rev6-7 support #107

Closed zoogie closed 6 years ago

zoogie commented 6 years ago

And maybe rev8 but I haven't seen anybody with this card yet.

We still need more command C7 samples from users to safely determine r4ids.cn revisions. @d3m3vilurr knows what I mean by this. Might need to open some rev4-5 issues and ask users as I did here: https://github.com/ntrteam/flashcart_core/issues/9#issuecomment-344408217

But this did work for me on my 3 r4igolds and at least two other users on rev6 and 7. This should complete full support for the r4ids.cn : )

d3m3vilurr commented 6 years ago

sorry @zoogie. I attached my experimental changes.

zoogie commented 6 years ago

rev4-5 is broken now.

This is wrong blowfish = encrypt firm_payload = encrypt firm_header = encrypt

This is right blowfish =plaintext firm_payload = encrypt firm_header = plaintext

d3m3vilurr commented 6 years ago

@zoogie yeah right. fixed my mistake.

zoogie commented 6 years ago

Alright, everything works now. LGTM Sorry about the whitespace issues, don't know what causes that. Next time I'll make sure it's cleaned up.

kitlith commented 6 years ago

@zoogie there's no need to go and explain specifically to me in the issues where you're asking these questions, it's fine. :stuck_out_tongue:

Might want to consider adding an enum to select the cart type, and also I think we're sticking with a relative include when including device.h, so #include "../device.h" was correct. \

LGTM!

angelsl commented 6 years ago

Best to stick with an include directive that is satisfied without assuming anything about the include paths defined by the application using us.

i.e. #include "../device.h"