Wrap ace3ds/r4sdhc.hk in an ifdef and rename r4sdhc_dualcore

[jason0597]

First change is that I wrapped the entire ace3dsplus.cpp and r4sdhc_dualcore.cpp files in #ifdefs.

There is an issue with them not being in an #ifdef. Suppose that e.g. you had flashcart_core and it was working fine, and then all of a sudden you get commits that support ace3dsplus, which is not yet fully finalized. After the ace3dsplus commits happen, you suddenly get some r4igold3ds fixes or something of the sort, fixes however that are stable and are able to be released. Now, if you want to release those r4igold3ds fixes (or really any other fix), well, you got to wait until ace3dsplus is fully finished before you mark a release. You can't really grab the latest flashcart_core as it is, with the, still in testing phase, ace3dsplus code and mark a release with that. However, if you could simply have a way to grab the latest flashcart_core, without having those testing phase devices be compiled, you could mark a release.

I made a corresponding pull request to ntrboot_flasher's makefile for the #ifdef changes

==============================================================

Second change that I did is rename the r4sdhc_dualcore.cpp file to r4igoldcc.cpp The r4sdhc_dualcore.cpp name is not a good name overall, as it causes confusion with the current r4isdhc.cpp.

The reason why I renamed it to r4igoldcc and not say r4isdhc.hk/r4itt/r4ixds is because the r4igold.cc issue is the one that has had the most responses (359!), and seemed to be the main place where the discussion was happening I also modified the corresponding lines (class declaration, logging, etc.) to match up with the filename change.

I also would like to note that I went ahead and wrote getDescription(). From all of the comments made on issue #3 , and from this comment, I went ahead and wrote that the r4isdhc.hk/r4itt/r4ixds should be compatible as well. This is theoretical and not proven.

[kitlith]

I agree with the rename of r4isdhc_dualcore to r4igoldcc. I agree that the old name was bad, it came from when I first looked at the flasher for a r4isdhc.hk cart, but later we supported the r4isdhc.com carts...

[jason0597]

commited changes

[angelsl]

I think the title should be "r4igold.cc" or just "R4i Gold". I'm inclined to the former, then we can rename R4iSDHC to r4i-sdhc.com or something like that, since all these carts don't really have a unique identifying name aside from the domain name, unlike Ace3DS or Acekard 2i.

[jason0597]

@angelsl there are so many ifs and buts everywhere that you have to explain a lot in the description all the clones, the exceptions, hw revisions, etc

e.g. the r4isdhc.com dual-core, the r4isdhc.hk dual-core, and the r4isdhc.com.cn dual-core are VERY different things. you can't really say all that in just the title

also, you can't put dots in the class name. though, it probably isn't that big of a deal since the developers can figure out which class belongs to which family of flashcarts

[angelsl]

Yes, I said "r4i-sdhc.com" specifically — note the TLD

[kitlith]

LGTM, I'll probably merge tonight after adding a commit to change the titles a bit.