Update the readme - Githubissues

ntrteam / flashcart_core

A hopefully reusable component for dealing with flashcart specific behavior.

GNU General Public License v3.0

126 stars 32 forks source link

Update the readme #122

Closed jason0597 closed 6 years ago

jason0597 commented 6 years ago

Seeing as it hasn't been updated in a while, it was time to update this to reflect the changes that have occured over the past few months.

Changes include:

Update the image and the list to show Ace3DS/GW blue/r4isdhc.com.cn Note that I have not included the older R4iGold revisions in the image. Possibly missing a few other carts as well.
Move from ds_ntrboot_flasher/ak2i_ntrcardhax_flasher to ntrboot_flasher_nds
Update the developer information to mention how flashcart_core is used now, and how you need ncgc for it now
Mention some extra people in the credits

Also, if you don't like the fact that I am hosting the image on dropbox, let me know

kitlith commented 6 years ago

LGTM.

I have some other changes I'd like to make to the README, but those don't have to happen right now.

kitlith commented 6 years ago

okay, so, apparently I completely missed the change from the d3m's flasher to your flasher in the readme, despite you pointing it out in the PR description.

@Hikari-chin already reversed that particular change, and if I had noticed it I wouldn't have allowed that. At the moment, we haven't moved toward officially supporting your flasher, nor has the guide. Will this change? Perhaps.

I would have been more okay with just adding your flasher to the list. At the very least, when I originally wrote the README, I planned for a section of users of this library. Blast, even if we decided to switch I'd probably still keep the link to the old flasher, and just mark it as deprecated and out-of-date or something.

jason0597 commented 6 years ago

I did list my changes, I thought you read them when you merged..... If you want to you can fork my flasher and do what you want with it (change the name, readme, rebrand it entirely, etc), then you won't need my approval for any changes you'd like to make

kitlith commented 6 years ago

Yeah, like I said, you listed your changes, and I didn't read them entirely. The point of the comment was to say something for the future, and as an explanation for why that change was undone.

I don't think we care about branding and whatnot, or that you're the maintainer instead of someone else. It's a matter of "testing" and official support, and not being ready to switch. (partially since I haven't been spending any time actually looking at stuff recently >_>)