search

ntrteam / flashcart_core

A hopefully reusable component for dealing with flashcart specific behavior.
GNU General Public License v3.0
128 stars 32 forks source link

Big refactor #61

Closed kitlith closed 6 years ago

kitlith commented 6 years ago

This has a lot of changes, for relatively little gain, so I'm leaving it here as a PR to look at before merging.

The main goal was deduplication/readability. I'm not sure how well I succeeded on the latter with the template functions. I'd definately like to hear any comments/suggestions for making that better. I also went ahead and changed the return value for readFlash and writeFlash from bool to uint32_t, since that's a more trivial change that I've already brought up doing.

Note to anyone who is not a developer: this does not add any new carts or features, it is exclusively a backend refactor. Don't. request. carts. on. this. PR.

I'm gonna head to bed now.

kitlith commented 6 years ago

Something is currently broken about this, and I'm not sure what because there are too many changes. I'm going to create a new branch that applies some of the improvements made here in smaller increments, see about getting those merged in, and then focus on merging those read/write loops.