search

ntrteam / flashcart_core

A hopefully reusable component for dealing with flashcart specific behavior.
GNU General Public License v3.0
128 stars 32 forks source link

Move platform-independent parts of NTR card interface here #71

Closed angelsl closed 6 years ago

angelsl commented 6 years ago

Still WIP: secure area reading, software Key2

kitlith commented 6 years ago

Reiterating that I think we should remove the static class wrappers around the functions now in the platform and ntrcard namespace, but it lgtm besides that.

Wrapping the whole thing in a, say, flashcart_core namespace could also be nice, but not a priority.

kitlith commented 6 years ago

Heck yeah. LGTM. @handsomematt how does this look to you?

kitlith commented 6 years ago

Handsomematt said this looks good. Merging.

d3m3vilurr commented 6 years ago

@angelsl why you made OpFlags, and why not exist reserialize method?