search

ntrteam / flashcart_core

A hopefully reusable component for dealing with flashcart specific behavior.
GNU General Public License v3.0
128 stars 32 forks source link

Add r4iGold (r4ids.cn) rev4-5 support #77

Closed zoogie closed 6 years ago

zoogie commented 6 years ago

Copypasta inheritance is not what I hoped for. It does work at least. Tested on my rev5.

d3m3vilurr commented 6 years ago
  1. why not divide from R4i_Gold_3DS
  2. it looks just little different between origin. how about adding multiple encrypt method & injectNtrBoot method to R4i_Gold_3DS? probably end users didn't know their cartridge type. but process can detect flashcart type at the initialize timing.
zoogie commented 6 years ago
  1. Already tried that (I assume you mean inherit from the R4i_Gold_3DS class?)
  2. I'm not sure how to do that. The rev4 and rev5 cart versions shows as 0, but so does rev6 and rev7, which this code doesn't support. Detect cart versions by timings sounds way out of my scope.
d3m3vilurr commented 6 years ago

@zoogie I made new pr about that. :)

d3m3vilurr commented 6 years ago

ah sorry, I was misunderstand about your comment. I meant just rev4/rev5 things. we need another detecting process for support rev6 and 7

kitlith commented 6 years ago

I think it's safe to close this PR in favor of @d3m3vilurr's PR.