Account for platforms that cannot reset and/or handover control to flashcart_core in KEY2

ntrteam / flashcart_core

A hopefully reusable component for dealing with flashcart specific behavior.

GNU General Public License v3.0

126 stars 32 forks source link

Account for platforms that cannot reset and/or handover control to flashcart_core in KEY2 #95

Closed angelsl closed 6 years ago

angelsl commented 6 years ago

Oh boy, please hold, I made a mistake.

angelsl commented 6 years ago

OK, mistake fixed.

angelsl commented 6 years ago

@d3m3vilurr

How about you fork my branch and make the necessary changes, then open a new PR.

kitlith commented 6 years ago

How about we think about merging this PR as-is, and then accept a PR changing a couple of things here & there.

kitlith commented 6 years ago

Overall, this LGTM. Merging.

d3m3vilurr commented 6 years ago

@kitling @angelsl actually I hate broken something if it works. refactoring process should not change anything. it means, if have a bug, should have the same bug. this rule is a more common sense of the programming. this patch includes refactoring code, (and yes also have add/change features, but I'm not telling about that. feature looks good.) but nobody checked this. anyway okay, I'll make patch about my comments.