search

ntrteam / ntrboot_flasher

🔓 Flash ntrboot to supported flashcarts using your 3DS.
https://3ds.hacks.guide/ntrboot.html
GNU General Public License v3.0
234 stars 33 forks source link

Dynamic loglevel #62

Closed TobiX closed 7 years ago

TobiX commented 7 years ago

Switches the loglevel constant to a variable and makes it possible to switch between INFO and DEBUG from the main menu using the Y button.

"Screenshot" Imgur

Technical details: I moved local code in platform.cpp from static to an anonymous namespace which feels more C++y to me.

Here's a test build for the lazy: https://up1.secretalgorithm.com/#XyfwMMe60Cx6bZdx9zjFQg

TobiX commented 7 years ago

I added a minor bug fix, so that every log line is written to SD immediately (thanks to @WinterMute for pointing that out), here is a new test build: https://up1.secretalgorithm.com/#jc6eivAFCn83kXGKBUDBVA

kitlith commented 7 years ago

LGTM, though it may be preferred to let the user scroll through all of the log level options.

Also, unless it's changed (haven't checked IRC yet today) fsync still didn't get everything flushed to disk. Still a good thing to put in, though.