ntt-sic / masakari

[UNMAINTAINED]
https://wiki.openstack.org/wiki/Masakari
Apache License 2.0
41 stars 25 forks source link

Apply code E265 and E501 of Flake8 for under ./masakari-controller #16

Closed Mahito closed 6 years ago

Mahito commented 8 years ago

Masakari doesn't have coding guideline. This PR introduces coding guideline for Python. However, it is difficult to fix all code check error. I apply code E265 & E501 for under ./masakari-under directory this time.

muroi commented 8 years ago

Thanks @Mahito. The kind of refactoring is very useful. Just one question. Why does test-requirements.txt have so many package's version? I expected it only has flake8 and/or pep8, and then other is setup by pip basing flake8's dependency.

Mahito commented 8 years ago

Hi, @muroi . thank you for your comments.

Just one question. Why does test-requirements.txt have so many package's version?

Sorry, It is my mistake. I would use only tox and flake8, but I used pip freeze > test-requirements.txt. I didn't know that pip freeze outputs some package's with version. I'll fix test-requirements.txt

Thanks!

ghost commented 6 years ago

Thanks for the updates.