search

ntt-sic / masakari

[UNMAINTAINED]
https://wiki.openstack.org/wiki/Masakari
Apache License 2.0
41 stars 25 forks source link

Fix instancemonitor init.d #23

Closed muroi closed 8 years ago

muroi commented 8 years ago

File name of instancemonitor is 'masakari_instancemonitor.py' not 'masakari-instancemonitor.py'. The inconsistency causes service starting error.

sampathP commented 8 years ago

@muroi Thank you for fix. This work with ubuntu. though, one point we have to keep in mind. In CentOS, process path of the instance_monitor is different. rpm package puts the script as /usr/bin/masakari-instancemonitor and 'ps' output give something similar. we have to make things consistent between rpm packaging and deb packaging. For now, I thing its better to leave comment in proc.list.sample file, but im not sure processmonitor,sh can skip the comment lines in proc.list.

muroi commented 8 years ago

I agree anytime we should support CentOS. But we need to fix it ASAP since instancemonitor isn't working now.

Currently, processmonitor doesn't support comment line in proc.list, so we have 2 options to work it.

  1. Enables processmonirot to work with comment line in proc.list and adds the comment to proc.list.sample
  2. Just adds the comment line to proc.list
  3. Adds the comment line to proc.list and https://github.com/ntt-sic/masakari-deploy supports it

Thought?

sampathP commented 8 years ago

Agree to fix this asap. If im correct, currently proc.list is deploy by ucf in debian postinst. Since processmonitor cant skip the comments, if we make commet in the file then it will make things more complex. So, my opnion is lets stick to original fix and raise an issue on github for centos. Sorry for made things coplex

sampathP commented 8 years ago

26 to address this issue for CentOS.