Closed rjarry closed 9 years ago
On a side note, I noticed your code removed the integer check. There is a reason for that value.strip("-").isdigit() check; A raised exception is quite a few times more expensive than the cost of that check, and without it, it throws two exceptions per _autocast() if the value is not a number, instead of just one for the float() call.
Edit: and thanks for the invitation, but I have enough stuff on my TODO list as it is :)
Hello ntt,
again thank you very much for your blazing fast reaction with our bug reports :)
In our project : Eve Corp. Management we use a slightly patched version of eveapi and I think that we made changes that could be interesting for you and others.
Here is a patch of our changes: http://pastebin.com/aEC5bJHX
Basically we changed the following:
scheme
argument (that defaults to"https"
to theEVEAPIConnection
function (to allow plain HTTP).except Error, reason:
-->except Error, e:
_autocast
function now converts dates to realdatetime
objects (easier to manage in Python than a unix timestamp).MalformedXMLResponse
exception that fires instead of theRuntimeError
if the<eveapi>
tag is not found.version
attribute of the<eveapi>
tag is now available through a<api_connection_obj>._meta.version
attribute.Feel free to integrate those changes in the official version :)
Also, and most important, we wanted to know if you'd be interested in helping on Eve Corp. Management. We would be thrilled if you were :-)
Thanks again for a wonderful piece of software!!!
diab