search

nttcslab-sp / kaldiio

A pure python module for reading and writing kaldi ark files
Other
249 stars 35 forks source link

Couple fixes #42

Closed danpovey closed 4 years ago

danpovey commented 4 years ago

Fixes the test failures noted in #41 and also the kaldiiio spelling error noted in #40 (but not the other part of #40). Note: for Kaldi I/O, keys should always be interpreted as utf-8 regardless of the system encoding.

codecov-io commented 4 years ago

Codecov Report

Merging #42 into master will increase coverage by 1.55%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   80.24%   81.79%   +1.55%     
==========================================
  Files           7        7              
  Lines        1306     1291      -15     
==========================================
+ Hits         1048     1056       +8     
+ Misses        258      235      -23
Impacted Files Coverage Δ
kaldiio/matio.py 90.1% <100%> (+2%) :arrow_up:
kaldiio/utils.py 83.83% <100%> (+5.94%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d9d4aae...2868052. Read the comment docs.

nttcslab-sp-admin commented 4 years ago

I see. Thank you for telling the accurate format. I was really surprised that you are seeing this program.