nttcslab-sp / kaldiio

A pure python module for reading and writing kaldi ark files
Other
248 stars 35 forks source link

Fix the issue related to the default encoding: #42 #43

Closed kamo-naoyuki closed 4 years ago

kamo-naoyuki commented 4 years ago

I changed to use utf-8 encoding as possible in any situations. This PR might cause the other unknown problems.

codecov-io commented 4 years ago

Codecov Report

Merging #43 into master will decrease coverage by 1.96%. The diff coverage is 47.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   81.79%   79.82%   -1.97%     
==========================================
  Files           7        7              
  Lines        1291     1294       +3     
==========================================
- Hits         1056     1033      -23     
- Misses        235      261      +26
Impacted Files Coverage Δ
kaldiio/utils.py 73.13% <47.05%> (-10.71%) :arrow_down:
kaldiio/matio.py 89.24% <0%> (-0.87%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5a50870...b7930bf. Read the comment docs.