nttdots / go-dots

go implementation of DOTS(DDoS Open Threat Signaling) https://datatracker.ietf.org/wg/dots/about/
Apache License 2.0
55 stars 14 forks source link

Conflicts with draft-ietf-dots-signal-channel #32

Open OlliV opened 5 years ago

OlliV commented 5 years ago

DOTS_protocol_specification_cheat_sheet.md refers to Content-Type option for CoAP while it should be called Content-Format. The content format is specified as application/cbor in the doc as well as in the source code but draft-ietf-dots-signal-channel specifies application/dots+cbor.

The URI-Path seems to be incorrect at least the cheat sheet as it specifies /.well-known/dots/v1/mitigate while the draft specifies /.well-known/dots/mitigate. The client code seems to be using the proper format but the server doesn't exactly verify it. By a quick look, it seems the server just looks if mitigate is defined in the URI, which isn't probably wrong as the draft mandates a certain order of options. To me it would sound reasonable to have versioned paths, too bad it's not currently allowed in the draft.