search

ntubiolin / xcos

83 stars 18 forks source link

Visiualization demo? #9

Closed RuoyuChen10 closed 2 years ago

RuoyuChen10 commented 3 years ago

Thanks for your work, I think it's a great idea for explainable face verification, however, I found confuse about one:

That's in visualize_xcos_one_example.ipynb, an example for visiualization, after define the model, it seems that didn't set:

model.eval()

And after I set model.eval(), the output is change.

Could you confirm this? Or something I may misunderstand for loading pretrained model?

Thx, looking forward to your rely!

ntubiolin commented 3 years ago

Thank you for pointing out the issue. I think it's a bug. The model.eval() should be added to the jupyter notebook. I will push a patched version later.

RuoyuChen10 commented 2 years ago

Thank you for pointing out the issue. I think it's a bug. The model.eval() should be added to the jupyter notebook. I will push a patched version later.

Thanks for your interesting work, I recommend adding the eval() function in the jupyter notebook.

Best wish.

ntubiolin commented 2 years ago

I have fix it in commit f85f0d4c9dd342536583c9a883b2217bcf6ad660. Thanks for reminding me!