search

ntucllab / libact

Pool-based active learning in Python
http://libact.readthedocs.org/
BSD 2-Clause "Simplified" License
776 stars 174 forks source link

allow uncertainty sampling to return score #103

Closed sian-chen closed 7 years ago

sian-chen commented 7 years ago

add parameter 'return_score' to allow user to get uncertainty score

codecov-io commented 7 years ago

Codecov Report

Merging #103 into master will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   88.28%   88.29%   +<.01%     
==========================================
  Files          33       33              
  Lines        1187     1188       +1     
==========================================
+ Hits         1048     1049       +1     
  Misses        139      139
Impacted Files Coverage Δ
libact/query_strategies/uncertainty_sampling.py 89.18% <100%> (+0.3%) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3408b78...6e846e0. Read the comment docs.

yangarbiter commented 7 years ago

Maybe you should open an issue and make sure the return_score parameter for make_query will be handled for other query_strategies.

Also you need to make sure the "score" is defined higher the better or lower the better (score should be higher the better) and write it to the docstring.