search

nturley / synthia

an IDE that uses myHDL, yosys, and arachne-pnr to target the ICEStick
MIT License
12 stars 1 forks source link

PR for #1 (and then some) #3

Closed CodeReclaimers closed 8 years ago

CodeReclaimers commented 8 years ago

Apologies for the delay, but here is a PR for the collection of changes I currently have here, including a fix for #1. If you'd prefer that I just break out the conversion changes, let me know and I can do that--I got a little out of hand while I was cleaning up, and I also removed the background processing because I was getting error messages from GTK whenever trying to show a MessageDialog, and wasn't able to find any other way to make them go away.

nturley commented 8 years ago

I like the refactor. I like the import in a separate process. I like removing the threading. I have mixed feelings about the new buttons. The point of this project was to create a minimalist UI. If we start adding too many buttons, it pulls attention away from the big friendly play button.

EDIT: I asked my girlfriend. She took your side on the buttons.

CodeReclaimers commented 8 years ago

I actually wasn't sure about the new buttons myself. The Open button is easier than having to choose File->Open from the menu every time after starting (especially if you're using Unity desktop or something), but the Save button is probably not that useful--the Verify and Deploy buttons both auto-save, and at this point I unconsciously save with Ctrl+S way too often anyway.

I like the idea of pushing to keep the UI minimalist, because I hate how many engineering tools eventually grow huge, confusing interfaces.