[Android Training] Simple To Do App - Completed

[ntvinhdev]

Hi /cc @vuminhkhang1995, I have already completed my Simple To Do App. Please give me a review. I found that I forgot a lot in SQL, Anyway, processing in SQL is better than file, so that now I take time to learn it again to switch from using file to SQL.
Thank you.

[minhkhang1795]

Hi,

Thank you for your submission

In general

• App works smoothly. Nice layouts and beautiful app icon 👍
• All the required features are done really well 💯
• Your code is quite clean and consistent.
• It's nice that you created your own Adapter and used DialogFragment
• It's great that the keyboard is automatically dismissed after typing the task's name.
• Nice to see that you created your own drawable file for button_save.

Details & Suggestions:

• Try to use SQL instead of text file in this assignment. It would be more efficient.
• In adapter, you can use a ViewHolder to keep reference to the view. It will increase performance of the ListView.
• ListView is not frequently used anymore. Developers now use RecyclerView instead. Please try it in your next assignment.
• In your item_task.xml, one RelativeLayout is enough. Delete the child RelativeLayout, and change layout_height of the parent RelativeLayout to wrap_content:

<?xml version="1.0" encoding="utf-8"?>
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:layout_margin="8dp"
    android:orientation="vertical">

    <TextView
        android:id="@+id/text_task_name"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_alignParentLeft="true"
        android:layout_alignParentStart="true"
        android:padding="8dp"
        android:text="Task Name"
        android:textAppearance="?android:attr/textAppearanceMedium"
        android:textColor="@color/colorText" />

    <TextView
        android:id="@+id/text_task_date"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_alignParentEnd="true"
        android:layout_alignParentRight="true"
        android:padding="4dp"
        android:text="MMM DD, YYYY"
        android:textStyle="italic" />

    <TextView
        android:id="@+id/text_task_priority"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_alignParentEnd="true"
        android:layout_alignParentRight="true"
        android:layout_below="@+id/text_task_date"
        android:padding="4dp"
        android:text="PRIORITY"
        android:textAllCaps="true"
        android:textStyle="bold" />

</RelativeLayout>

• If you want to create an app icon, you can use Image Asset generator in Android Studio. It will generate different sizes for your icon (xxxhdpi, xxhdpi, xhdpi,...). To use the generator, right click on drawable folder -> New -> Image Asset

[ntvinhdev]

Thanks for your detailed review. I changed from using text-file storage to SQL storage. Everything works well now.