search

ntzwrk / blockstack.ts

work in progress, please check back later
MIT License
10 stars 1 forks source link

Clarify whether `getGracePeriod()` needs a parameter or not #7

Closed vsund closed 6 years ago

vsund commented 6 years ago

Hey @kantai, the getGracePeriod() in src/network.js doesn't take a parameter according to the implementation there. But in src/operations/safety.js you pass the fullyQualifiedName through to getGracePeriod().

Does getGracePeriod() needs the name as parameter? I currently assume yes, in case the grace period depends on the namespace (see commit https://github.com/ntzwrk/blockstack.ts/commit/329c6a601bf67380eaa5ed6b9122e075802f33e6).

kantai commented 6 years ago

Currently doesn't need the name as a parameter.

vsund commented 6 years ago

Removed it in d37794572d299111e8150fdaabeef65a44ce4841 from that call. Should I remove the parameter upstream in src/operations/safety.js too?

vsund commented 6 years ago

Solved in https://github.com/ntzwrk/blockstack.ts/commit/d37794572d299111e8150fdaabeef65a44ce4841. If I should fix this in blockstack.js leave me a message @kantai :)