search

nu-radio / NuRadioReco

reconstruction framework for radio detectors of high-energy neutrinos
GNU General Public License v3.0
5 stars 3 forks source link

New module antennadedispersion #150

Closed cg-laser closed 5 years ago

cg-laser commented 5 years ago

Adds a new module that dedisperses antennas.

Also fixed a typo in the detector module in the function get_antanna_orientation

christophwelling commented 5 years ago

It's a typo fix. antAnna -> antEnna

cg-laser commented 5 years ago

oki doki, I cleaned up the module. I also added a check to the efieldToVoltage converter to check if a station has any efields.

anelles commented 5 years ago

Thanks, can you update the docstring in get_antenna_orientation ? It now talks about connectors. If we add here, what we mean for dipole and LPDA, I think this would alleviate some confusion.

cg-laser commented 5 years ago

Thanks, can you update the docstring in get_antenna_orientation ? It now talks about connectors. If we add here, what we mean for dipole and LPDA, I think this would alleviate some confusion.

@anelles done