search

nu-radio / NuRadioReco

reconstruction framework for radio detectors of high-energy neutrinos
GNU General Public License v3.0
5 stars 3 forks source link

add new power integration trigger module #179

Closed cg-laser closed 4 years ago

cg-laser commented 4 years ago

The test is failing because of the recent NuRadioMC change (pulse position in trace). @christophwelling can you update the reference? I'm not sure how to do it.

christophwelling commented 4 years ago

I updated the NuRadioReco reference, but the NuRadioMC test is still failing. I don't know what's up with that, but it has to be fixed in NuRadioMC. FYI: The comparison scripts in the tests have the option --create_reference. If you use that, instead of comparing the reco results to reference, the script will create a new reference.

anelles commented 4 years ago

Actually in my pull request about the logging, the reference is fixed and works ...

On Thu, Jan 23, 2020, 16:13 christophwelling notifications@github.com wrote:

I updated the NuRadioReco reference, but the NuRadioMC test is still failing. I don't know what's up with that, but it has to be fixed in NuRadioMC. FYI: The comparison scripts in the tests have the option --create_reference. If you use that, instead of comparing the reco results to reference, the script will create a new reference.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nu-radio/NuRadioReco/pull/179?email_source=notifications&email_token=AC663BIM5QRTEUTLYYSB3EDQ7GXZ5A5CNFSM4KKK2VDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJXWBQQ#issuecomment-577724610, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC663BP7OUD5N7DIRA2537LQ7GXZ5ANCNFSM4KKK2VDA .

cg-laser commented 4 years ago

It's again the Veff test. Restarting the test just worked.