search

nu-radio / NuRadioReco

reconstruction framework for radio detectors of high-energy neutrinos
GNU General Public License v3.0
5 stars 3 forks source link

change internal looping in NuRadioMC #222

Closed cg-laser closed 4 years ago

cg-laser commented 4 years ago

corresponding PR to https://github.com/nu-radio/NuRadioMC/pull/208

christophwelling commented 4 years ago

Looks good so far. Can you add a has_shower method to the event class to check if there is already a shower with a given ID?

anelles commented 4 years ago

@cg-laser per code cleaning up, we should try to merge this. @christophwelling you would need to accepted the changes in order to make is mergable.

christophwelling commented 4 years ago

Please put the iter_channels method from the Station and SimStation class into the BaseStation class, then I think this can be merged.

cg-laser commented 4 years ago

The SouthPole test will fail because of the random seeds changes. So I need to update this. But before that, I need to merge the corresponding NuRadioMC changes into the internal-looping branch. For this I'm waiting on @anelles feedback/approval on the NuRadioMC pull request (the noise temperature one).