search

nu-radio / NuRadioReco

reconstruction framework for radio detectors of high-energy neutrinos
GNU General Public License v3.0
5 stars 3 forks source link

setting antenna model by depth is now optional and can be deactivated #226

Closed cg-laser closed 4 years ago

cg-laser commented 4 years ago

So far the depth of the antenna was used to automatically determine if the antenna is in firn or in air. This PR makes this option optional which is useful for simulation studies. It will be made the default in NuRadioMC

daniel-zid commented 4 years ago

It looks fine and it works on my machine.

If we're going to call the detector with antenna_by_depth=False from NuRadioMC, shouldn't we adapt the generic detector as well?

daniel-zid commented 4 years ago

It looks good!