search

nu-radio / NuRadioReco

reconstruction framework for radio detectors of high-energy neutrinos
GNU General Public License v3.0
5 stars 3 forks source link

Update antenna docs #238

Closed clark2668 closed 4 years ago

clark2668 commented 4 years ago

Issue being addressed:

This updates the antenna documentation to fix some mistakes, and add clarifying content.

clark2668 commented 4 years ago

Sure! I wrote a reply inline above.

clark2668 commented 4 years ago

no problems, will go ahead and merge

clark2668 commented 4 years ago

oh, actually, I guess I can't because I don't have write permissions. can you do the merge @cg-laser?

cg-laser commented 4 years ago

you should have write permissions. Just just need an approving review (which I just did). But we have the policy to wait 24h before we merge so that everyone has the opportunity to comment.

clark2668 commented 4 years ago

Hmm, the only option it shows me is "close and comment", and it says "Only those with write access to this repository can merge pull requests." So it doesn't seem like I can?

But good point, we will wait till tomorrow in any case!

cg-laser commented 4 years ago

Yes you're right. I gave you write access now.