search

nu-radio / NuRadioReco

reconstruction framework for radio detectors of high-energy neutrinos
GNU General Public License v3.0
5 stars 3 forks source link

Adds automatic linting for PRs #250

Closed christophwelling closed 4 years ago

christophwelling commented 4 years ago

This should automatically run a linter for every new pull request

anelles commented 4 years ago

I have to admit that I had to google what this does ... but nice initiative. I like it. Not sure we always want to lint the whole code base though. How about we do this once and then only what is new in the PR?

christophwelling commented 4 years ago

Yes, I will set it back to only lint changed files once this is done. But I first want to make sure that all the code is in a good state. Same goes for linting on every commit: This is useful now for making sure everything works, but I can set it back once I'm done.

cg-laser commented 4 years ago

@christophwelling sorry for my ignorance, but I still don't see where I can see the linter results. Can you add a short description and/or post a screenshot?

christophwelling commented 4 years ago

linter_screenshot

cg-laser commented 4 years ago

thanks, and we don't see any errors because you already fixed everything?

christophwelling commented 4 years ago

Yes. The older commits have plenty of errors ;-)

cg-laser commented 4 years ago

Got it thanks, is there a way to only show the errors?

christophwelling commented 4 years ago

As far as I know not, but it is set to only check files that were changed in the pull request. So this should not be an issue for other PRs

christophwelling commented 4 years ago

The linter doesn't, but PyCharm has a spell check. Most of its complaints are not very useful, but sometimes it actually finds something.

cg-laser commented 4 years ago

@christophwelling shall we merge this one?

christophwelling commented 4 years ago

I would like to merge the fourier shift PR first and make sure everything works. Can you approve that one?