search

nu-radio / NuRadioReco

reconstruction framework for radio detectors of high-energy neutrinos
GNU General Public License v3.0
5 stars 3 forks source link

Adds function to get the amp response directly from the detector class #262

Closed christophwelling closed 3 years ago

christophwelling commented 4 years ago

It's annoying to always use the analog_components modules manually every time you need the amp response. This PR simplifies things

christophwelling commented 3 years ago

Having a list of amps in the analog components is a good idea, I will add that. I'm not sure about having the experiment as a parameter. The detector class itself should have all the information it needs to find the right amplifier. Otherwise this is can easily cause issues if we want to use it inside modules, where we can't easily change how this is called from the outside. Could somehow add the name of the experiment to the detector description?

christophwelling commented 3 years ago

I changed it so we get the amp names from the analog_components file now. It now also raises an error if the amp name is not unique