search

nu-radio / NuRadioReco

reconstruction framework for radio detectors of high-energy neutrinos
GNU General Public License v3.0
5 stars 3 forks source link

SimChannels for cosmic ray events #265

Closed christophwelling closed 3 years ago

christophwelling commented 3 years ago

Makes the efieldToVoltageConverterPerEfield consider signal travel times between channels for cosmic ray events, so simChannels can be used for CR as well

christophwelling commented 3 years ago

I don't understand what you mean. This is the exact same thing as in the efieldToVoltageConverter.

cg-laser commented 3 years ago

Yes I know. The functionality is also limited in that module. For ARIANNA, all antennas are at the same depth, so it does not matter. But for other configurations it might matter. I'm not saying that we need to implement it in this PR, but it will be helpful to mention that limitation in a comment in the code. I would also mention, that for cosmic rays, we simulate just one efield for each station

christophwelling commented 3 years ago

Ah, I didn't consider the different index of refraction between air and ice. I added a comment explaining this