search

nu-radio / NuRadioReco

reconstruction framework for radio detectors of high-energy neutrinos
GNU General Public License v3.0
5 stars 3 forks source link

Event browser #276

Closed cg-laser closed 3 years ago

cg-laser commented 3 years ago

fix association of channel ids with channel index.

To mitigate potentially out of order channels in the detector description, the detector now returns a sorted list.

cg-laser commented 3 years ago

I ran test manually and they pass.

cg-laser commented 3 years ago

I wonder if this is potentially dangerous. Because then the order is silently changed and would e.g. not correspond to the order we have in the hdf5 files. The change I made would in principle also effect if simulations were already produced and if the channel order is rerequsted by the detector. But this is not what one would do normally. The iter_channels method is used and then the channel_id is used to extract certain parameters.