search

nu-radio / NuRadioReco

reconstruction framework for radio detectors of high-energy neutrinos
GNU General Public License v3.0
5 stars 3 forks source link

fix trigger time adjuster #277

Closed cg-laser closed 3 years ago

cg-laser commented 3 years ago

in case no trigger, the trigger time was set to 0 which screwed up the logic in the triggerTimeAdjuster module. I made the triggerTimeAdjuster module more robust and changed the trigger modules to leave the trigger time at None if no trigger was registered. I noticed that because the traces were not cut correctly.

cg-laser commented 3 years ago

the tests on NuRadioReco run fine, but the tests on NuRadioMC fail because of differences in the maximum amplitudes because the traces are now cut to different parts. We will need to fix this in NuRadioMC.