nu-radio / NuRadioReco

reconstruction framework for radio detectors of high-energy neutrinos
GNU General Public License v3.0
5 stars 3 forks source link

MONGODB_URL, Dockerfile #285

Closed shallmann closed 3 years ago

shallmann commented 3 years ago

-MongoDB uses MONGODB_URL if set, otherwise it defaults to previous implementation

cg-laser commented 3 years ago

just a quick comment: Executing the index.py file to start the server is only for debug purposes. The production server should be started with guincorn

shallmann commented 3 years ago

@cg-laser

I just copied over the Dockerfile from Philipps fork. I can add a description to build/start the container locally (accessing the dash from a local container only runs with my last change in index.py)?

My main intention was the request to add the MONGODB_URL environmental variable

cg-laser commented 3 years ago

I thought you could just add a README file in this subdirectory with the instructions how to run it. Then the information is easy to find

shallmann commented 3 years ago

done

as in the instructions it is not in a subdirectory though... better move Dockerfile/readme to e.g. NuRadioReco/detector/webinterface ?

shallmann commented 3 years ago

Good news! After discussions with Philipp on Friday, we are now able to deploy ourselves via jenkins. Currently this branch is used in deployment, and with the latest change, I verified:

See attached screenshots.

screenshot 2021-01-24 at 03 06 21 screenshot 2021-01-24 at 02 47 30

Should we merge?