search

nu-radio / NuRadioReco

reconstruction framework for radio detectors of high-energy neutrinos
GNU General Public License v3.0
5 stars 3 forks source link

Channel time offset calculator #289

Closed christophwelling closed 3 years ago

christophwelling commented 3 years ago

Adds module to that calculates the expected signal time difference between channels (along with some other properties) for a given vertex position. It does this by calculating correlations between channels and a template to determine the most likely scenario.

anelles commented 3 years ago

@lpyras and @shallmann I assigned you just to spread the load a bit on reviewing. Please try to take a look at this code before the end of next week.

shallmann commented 3 years ago

@christophwelling looks fine to me. Three minor comments, that are not obvious to me right away: 1/ L102f: why is correlation_size = a + b + 1? if you calculate a xcorr you would indeed get a length of a + b - 1 no? 2/ station "101" is used hard coded. I should know that myself already, but do we assume it exists always by convention? 3/ L142: I guess you know what you are doing. It was not obvious right away to me, can you comment on what is calculated here? (antenna_response['theta'] + antenna_response['phi']) gives you a summed amplitude?

christophwelling commented 3 years ago
  1. Yes, it should be a + b -1. Fixed that.
  2. No, hardcoding station 101 was not intentional. Thanks for spotting.
  3. It just assumes that the electric field is equally polarized in theta and phi component. It's useful so we don't have to worry where the antenna is more sensitive. I added a comment.