Prevent interference between Detector instances

nu-radio / NuRadioReco

reconstruction framework for radio detectors of high-energy neutrinos

GNU General Public License v3.0

5 stars 3 forks source link

Prevent interference between Detector instances #294

Closed christophwelling closed 3 years ago

christophwelling commented 3 years ago

Turns the SerializationMiddleware from TinyDB from a global variable into an attribute of the Detector class. This makes sure that each detector instance gets its own SerializationMiddleware object, to prevent interference between Detector instances.

Fix for #288

@cg-laser This breaks the script NuRadioReco/detector/sql_to_json.py I don't understand what this script is for or if we even need it any more.

clark2668 commented 3 years ago

Hi Christoph, thanks for taking care of this so quickly! I get the expected behavior now. I'm afraid I can't comment on the NuRadioReco/detector/sql_to_json.py though.

anelles commented 3 years ago

@clark2668 Can you review this? You already took a look and I think it is easiest, if you check this as reviewer. We are trying to get NuRadioReco cleaned up before the end of next week. Thanks!

clark2668 commented 3 years ago

Sure, I'll take a look! I think I only have one final point of confusion.