search

nu-radio / NuRadioReco

reconstruction framework for radio detectors of high-energy neutrinos
GNU General Public License v3.0
5 stars 3 forks source link

3D vertex reconstruction #295

Closed christophwelling closed 3 years ago

christophwelling commented 3 years ago

Adds a module for a full 3D neutrino vertex reconstruction as well as a documentation on how to use the vertex reconstruction modules.

lpyras commented 3 years ago

Ok with me. @lpyras what was your worry on parameters x, r?

Just that x_min is defined by r_min. But nothing serious.

shallmann commented 3 years ago

Ah, ja, right... I leave the decision to Christoph if he feels like renaming the x_, ix, xx to r, i_r, rr...

anelles commented 3 years ago

I didn't have a look at the module, but because it is an isolated reconstruction module, it is save to merge.

I agree that it is save to merge, but just for the sake of code quality, I think we should also review analysis modules. And if only to keep people on their toes about writing legible code.