Using "observation_level" in get_atmosphere() throughout the models.py

nu-radio / radiotools

A tool package for cosmic-ray and neutrino radio detectors

GNU General Public License v3.0

8 stars 5 forks source link

Using "observation_level" in get_atmosphere() throughout the models.py #41

Closed fschlueter closed 3 years ago

fschlueter commented 3 years ago

Hi @cg-laser, this is related to the merged PR #38. The observation level have to be used consistently in functions like: _get_vertical_height_numeric or _get_distance_xmax. Do you agree? What I do not quite see is how that effects the calculation via taylor expansions. It is necessary to just include the obersvation_level there too? Or does one need to repeat the determination of the used parameter. Cheers

fschlueter commented 3 years ago

This issue is currently addressed with #45

fschlueter commented 3 years ago

solved with PR #45