lguelzow
commented
2 months ago Everything should be addressed now. I merged master into the branch to resolve the conflicts and I added a new file with @fschlueter's functions to estimate the cherenkov radius (hope that's alright to add), so there's no external ddependencies.
Changes to models.py:
added 2 atmosphere models for experimental sites in China for GRAND removed a deprecated module that didn't run for me (xrange -> range) slightly widened a range in an atmospheric height calculation because it crashed for the 50-200 MHz frequency band
Changes to coordinatesystems.py:
just a typo in a print command
Changes to generate_coreas_sim.py:
extensively expanded the "write_list_star_pattern" function with detailed documentation. Everything new is at least briefly described. The default output of the function stays the same. The main change is to replace the undocumented rotation by -90 degrees to transform to the Auger coordinate system with an explicit rotation matrix that is well documented. It also enables generating starshapes in Corsika's native coordinate system with a new input option: Auger_CS. By default it is set to True and performs the same -90 degree rotation as the current version of the code. Error messages are included to catch inputs in the wrong units for angle and distances. The function also now returns the azimuth angle that has to be written in the Corsika input to get the right shower direction for the corresponding starshape. Added another optional input option to the function that writes a second .list file containing antenna positions in the shower plane coordinate system to enable visual checks of the starshape.
Added new functions to generate pre-made antenna rings with variable density that can conform to the shower geometry.