Open coolaj86 opened 3 years ago
I'm not distributing binary build because of this (quoted from NOTICE of FDK-AAC library):
3. NO PATENT LICENSE
NO EXPRESS OR IMPLIED LICENSES TO ANY PATENT CLAIMS, including without
limitation the patents of Fraunhofer, ARE GRANTED BY THIS SOFTWARE LICENSE.
Fraunhofer provides no warranty of patent non-infringement with respect to this
software.
You may use this FDK AAC Codec software or modifications thereto only for
purposes that are authorized by appropriate patent licenses.
Yuck.
For some reason I was under the impression that AAC was owned by Apple and that it was royalty free. Maybe that's just m4a... or maybe I just dreamed it up.
Additional resources, for others following:
(Apple isn't even on the list of owners, oddly enough)
wrt patents:
The patent terms are funny. It covers encoders and decoders equally. Although FFmpeg does not have the ability to encode all the fancy ELD, HE, whatever stuff, it can decode all of them, and hence should be hit as hard as fdkaac
.
To follow
Maybe I can find a stronger argument. Debian is perfectly happy to distribute fdk-aac https://packages.debian.org/source/sid/fdk-aac despite its qualms about the "oh no it's banning people from charging for the code so it's non-free" business. Debian, as in the linux distribution more serious about license issues than the FSF.
There is a stripped down version of FDK-AAC https://gitlab.freedesktop.org/wtaymans/fdk-aac-stripped
This fdk-aac fork is stripped from parts with patent concerns (i.e. HE (High Efficiency) and HEv2 profiles). The Fedora Legal team has approved this fork. https://bugzilla.redhat.com/1501522
https://repology.org/project/fdk-aac-free/versions
Here is fdkaac built with stripped fdk-aac fdkaac-1.0.6-x64.zip
Would you mind uploading compiled binaries to Github Releases?
It seems like this project is pretty much complete, so it's probably not worth worrying about setting up any sort of automated build process since just one upload every few years would seem to suffice.
Build Instructions
I have some instructions for how to build on Mac and Linux, and I'd be happy to supply binaries for those two (including Apple Silicon M1). \ (my process is documented here: https://github.com/coolaj86/fdkaac/releases/tag/v1.0.1-pre-1)
Trustable 1st Party Builds
I realize that I could host these on my own Github page (which I'm doing for a client currently), but I'd like to get this up on Webi (webinstall.dev) as well, and we try to avoid 3rd party builds whenever possible since people generally trust 1st party builds more (and they generally work as documented).