nu774 / qaac

CLI QuickTime AAC/ALAC encoder
Other
822 stars 42 forks source link

FLAC metadata improperly copied if it contains NULL delimiter #101

Open noahdominic opened 6 months ago

noahdominic commented 6 months ago

Hello,

I think I found an error.

If a field contains multiple values separated with the NULL delimiter [ rendered differently on different players; appears on mp3tag as double backslash (\\), appears on foobar2000 as comma+space (,) ] , only the last item is copied.

For example, if the input's composer is Gaspard Auge\\Xavier de Rosnay\\Kevin Parker, the ouput's composer ends up just being Kevin Parker

How to replicate

  1. Get a FLAC file with one of the fields containing multiple values separated with the NULL delimiter.
  2. Convert to AAC using qaac input.flac.
  3. See that only the last item is copied

Software used

In case it might be relevant, I ran this on MS Windows 11 Version 23H2 (Build 22631.3593) using Powershell 7.4.2 and 5.1.22621.2506.

Here is the output of qaac --check:

qaac 2.82, CoreAudioToolbox 7.10.9.0
libsoxconvolver 0.1.0
libsoxr-0.1.3
libFLAC 1.3.4
nu774 commented 6 months ago

qaac just doesn't support multiple tag values in single field by design.