search

nuagenetworks / bambou

low level rest communication library for vsp style apis
BSD 3-Clause "New" or "Revised" License
7 stars 11 forks source link

fix headers #12

Closed little-dude closed 8 years ago

little-dude commented 8 years ago

@t00f I think the test is wrong here: we do have an externalID attribute, don't we ?

t00f commented 8 years ago

Yes, we do have an externalID

t00f commented 8 years ago

Your PR looks good to me. You should launch unit tests locally to ensure everything is working.

little-dude commented 8 years ago

@t00f this is ready, once you reviewed the commit that fixes the tests. I'll make a release when this is merged.

t00f commented 8 years ago

Looks good ! Thanks @little-dude