search

nuagenetworks / bambou

low level rest communication library for vsp style apis
BSD 3-Clause "New" or "Revised" License
7 stars 11 forks source link

Python3 support plans ? #13

Closed zerxen closed 6 years ago

zerxen commented 7 years ago

Python3 support plans ?

bambou and on it dependant vspk are not capable of running on python3 in current state:

E.G typical type casting issues like: File "C:\Users\havrila\AppData\Local\Programs\Python\Python36\lib\site-packages\bambou\nurest_session.py", line 150, in _in_with_statement return opname[ord(frame.f_code.co_code[frame.f_lasti + 3])] is "SETUP_WITH" TypeError: ord() expected string of length 1, but int found

little-dude commented 7 years ago

That's really something we should do yes. I don't have an eta yet though. @pdellaert thought?

pdellaert commented 7 years ago

Agree on the requirement for this, let us look how we can plan this :)

zerxen commented 7 years ago

Great, thanks for consideration.

And gentlemen while we are at it, how much is vspk and all this github stuff officially supported and kept up to date with Nuage releases? I am actually on commercial evaluation between my company and Nokia pre-sales (can pull you into that on request). But can we make vspk target API for development of our Nuage orchestration, or should we fallback rather on direct REST API.

pdellaert commented 7 years ago

@zerxen The Nuage VSPK-Python is officially supported and is used in a lot of platforms and at customers.

As you might have noticed on the VSPK-Python (and other VSPKs), there are official releases matching our Nuage VSP releases. Our VSPKs are automatically generated every time we release a new version (minor and major) so the VSPKs are always up to date with our API's.

zerxen commented 7 years ago

Thanks, appreciate the response.

dcotruta commented 7 years ago

Hi there. I'm a developer currently working on a rather large Nuage rollout. I'd like to volunteer to port this to Python3(.6). Of course, after that, I'd need to port VSPK-Python but I figure if I did this first it might generate some movement on that project.

It nearly the end of 2017. Python 3 has been out for almost 10 years. We can't carry on with 2.x code.

little-dude commented 7 years ago

@dcotruta you'd have to start with bambou which is the library that does the actual requests. I think porting to python3 should be quite easy as long as we don't support python 2.6 anymore. @pdellaert do we still have to support python 2.6?

I agree that it's urgent to start supporting python 3 at this point...

pdellaert commented 7 years ago

Agreed on python 3 support urgency. I didn't know we support python 2.6? I do want python 2.7 compatibility...

@dcotruta, any help is welcome, but please understand that our own QA organisation will also have to run verifications before any external PR's will be merged/accepted as we need to guarantee compatibility

pdellaert commented 6 years ago

Provided 3.0 support since release 3.0 of bambou (and used in VSPK 5.2.2 and above)