VSD hostnames cannot contain hyphen character

[pmjordan]

vsd-deploy/main includes a loop to Update /etc/hosts file on VSD cluster. This loop fails to run if the hostnames contain a hyphen.

[pmjordan]

My work around is to use a sequence of three commands:

• name: Update /etc/hosts file on VSD cluster lineinfile: dest: /etc/hosts

  can't use next line and loop as hostvars['item'] evaluates to a hostname which contains hyphens and they are not allowed in variable names

  #line: "{{ hostvars['item']['mgmt_ip'] }}    {{ hostvars['item']['hostname'] }}"
  line: "{{ hostvars[third_cluster_node_to_install]['mgmt_ip'] }}    {{ hostvars[third_cluster_node_to_install]['hostname'] }}"

  with_items: groups['vsds']

  remote_user: "{{ vsd_default_username }}"

• name: Update /etc/hosts file on VSD cluster lineinfile: dest: /etc/hosts line: "{{ hostvars[first_cluster_node_to_install]['mgmt_ip'] }} {{ hostvars[first_cluster_node_to_install]['hostname'] }}" remote_user: "{{ vsd_default_username }}"
• name: Update /etc/hosts file on VSD cluster lineinfile: dest: /etc/hosts line: "{{ hostvars[second_cluster_node_to_install]['mgmt_ip'] }} {{ hostvars[second_cluster_node_to_install]['hostname'] }}" remote_user: "{{ vsd_default_username }}" when: vsd_sa_or_ha |match('ha')

[ghost]

We use host names that contain '-' in our tests. It looks like the code you have pasted has extra ' chars that don't appear in the current MetroÆ code. From vsd-deploy/tasks/main.yml we see this:

• name: Update /etc/hosts file on VSD lineinfile: dest: /etc/hosts line: "{{ hostvars[item]['mgmt_ip'] }} {{ hostvars[item]['hostname'] }}" with_items: "{{ groups['vsds'] }}"

Can you retry after removing the ' chars around item?

[pmjordan]

You are correct. The bad syntax may have occurred when I tried to take your early patch fix. Anyway I confirm that your code is fine and apologies for this one.

Paul Jordan Specialist Solution Designer – Network OSS Design Dynamic Networks | Dynamic Infrastructure | BT Technology, Service & Operationshttps://intra.bt.com/bt/tso | Tel: +44 (0) 1473629289<tel:+441473629289> | paul.m.jordan@bt.commailto:paul.m.jordan@bt.com This email contains information from BT that might be privileged or confidential. And it's only meant for the person above. If that's not you, we're sorry - we must have sent it to you by mistake. Please email us to let us know, and don't copy or forward it to anyone else. Thanks. We monitor our email systems and may record all our emails. British Telecommunications plc R/O : 81 Newgate Street, London EC1A 7AJ Registered in England: No 1800000

From: Brian Castelli notifications@github.com Sent: 17 April 2019 16:44 To: nuagenetworks/nuage-metro nuage-metro@noreply.github.com Cc: Jordan,PM,Paul,TNK6 R paul.m.jordan@bt.com; Author author@noreply.github.com Subject: Re: [nuagenetworks/nuage-metro] VSD hostnames cannot contain hyphen character (#1086)

We use host names that contain '-' in our tests. It looks like the code you have pasted has extra ' chars that don't appear in the current MetroÆ code. From vsd-deploy/tasks/main.yml we see this:

• name: Update /etc/hosts file on VSD lineinfile: dest: /etc/hosts line: "{{ hostvars[item]['mgmt_ip'] }} {{ hostvars[item]['hostname'] }}" with_items: "{{ groups['vsds'] }}"

Can you retry after removing the ' chars around item?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/nuagenetworks/nuage-metro/issues/1086#issuecomment-484146123, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ad0uX3jz2BYkrt9LtOz8eNoN-STCMVlXks5vh0FbgaJpZM4cdJOR.