Improvement for metroae container ssh copyid - Githubissues

nuagenetworks / nuage-metroae

Nuage Networks Metro Automation Engine

http://devops.nuagenetworks.net

Apache License 2.0

44 stars 17 forks source link

Improvement for metroae container ssh copyid #1730

Open toweber opened 3 years ago

toweber commented 3 years ago

Would it be possible to make this command usable without specifying a host so that the ssh key is copied to all required hosts present in the deployment files? Right now if I want to start using the metroae container for an already existing deployment I have to run metroae container ssh copyid for all deployed components (except VSCs ofc).

ghost commented 3 years ago

This is a great suggestion. I will create a JIRA ticket to track this internally. Thank you.

ghost commented 3 years ago

METROAE-419 has been created.

toweber commented 3 years ago

Thanks a lot! Will this include all Nuage components (linux based, not VSC of course) as well as target servers? Or only a subset?

ghost commented 3 years ago

We will support Linux-based components and Linux-based target servers. We will use the credentials provided in credentials.yml or default credentials when credentials are not provided.

toweber commented 3 years ago

Okay. I was just looking at the dev branch and could only find this role: https://github.com/nuagenetworks/nuage-metroae/blob/dev/src/roles/make-copy-sshid-automatic/tasks/main.yml And this one only includes VSD and VSTAT so I was wondering if the other components as well as their target servers are also considered.

ghost commented 3 years ago

@toweber you are correct. I was wrong. The implementation that we delivered to the dev branch only covers VSD and VSTAT. Your question suggests that we should add KVM-based target servers. Since we don't support upgrade of NUH and VNSUtils, it seems that there are no other VSP components to add support for. What am I missing?

toweber commented 3 years ago

One thing that I can think of would be if MetroAE only takes care of the "deploy" but not the "predeploy". For that scenario I guess it would also be valuable / convenient to be able to copy the ssh key to NUH (or vnsutils). Currently seeing this with my customer. They have a separate team that only takes care of VM provisioning in VMWare up until IP connectivity. What do you think?

ghost commented 3 years ago

In v4.5 (about to be released) we have the following workflows:

metroae vsd copy sshid that copies '~/.ssh/id_rsa.pub' to all VSDs in the deployment. This can be helpful in the scenarios when the VM bring-up is done outside of MetroAE or we are doing an upgrade on something that existed previously.
metroae vstat copy sshid that does the above for the ES nodes defined in the deployment.
metroae container ssh copyid that copies the MetroAE container's ssh key to the specified host

from this discussion, I think additional functionality should be considered:

Add NUH to the list of supported nodes.
Add target servers to the list of supported nodes.
Add support for copying the container's ssh key to VSD, ES, NUH and target servers. (Not a separate workflow. Code should be smart enough to detect when the container is being used...)
Add a workflow for copying to all nodes in a single operation.
Add support for specifying the ssh key file to copy - might not be the default in the non-container case.

@toweber what do you think?

ghost commented 3 years ago

METROAE-445 has been created to track this issue.

toweber commented 3 years ago

That sounds great!