search

nuagenetworks / nuage-metroae

Nuage Networks Metro Automation Engine
http://devops.nuagenetworks.net
Apache License 2.0
44 stars 17 forks source link

Obsolete hmac-sha1 MAC Cipher no longer valid in newer versions of 20.10 #1990

Closed Eraldoe closed 1 year ago

Eraldoe commented 1 year ago

https://github.com/nuagenetworks/nuage-metroae/blob/67cd8c8996c4717ac0a4021789fa86cdf83488f2/src/roles/vsc-deploy/templates/ssh_hardening.cfg.j2#L41C43-L41C43

When running metro with 20.10R13 it failed with the following error:

MAJOR: CLI #1009 An error occurred while processing a CLI command - File cf1:\config.cfg, Line 82: Command "mac 215 name hmac-sha1" failed.

I confirmed in the VSC CLI that in that version hmac-sha1 is no longer available as an option.

I don't think we can simply remove this line if clients depend on it in lower versions. Can we add to the jinja template to remove this line selectively based on version greater than 20.10R12 (do need to confirm the exact version we obsoleted this cipher)

nokia-dahal commented 1 year ago

Noted. Will be fixed in new release.