search

nuagenetworks / nuage-ospdirector

OSP Director integration for Nuage VSP
https://github.com/nuagenetworks/nuage-ospdirector/wiki
Apache License 2.0
16 stars 33 forks source link

Use relative path instead of absolute path to /usr/share #130

Open jbemmel opened 4 years ago

jbemmel commented 4 years ago

deployment fails without this

sjabasti commented 4 years ago

This does not seem right. Can you share the failure of your deployment? (when not applying this change) From which directory and user are you running the overcloud deploy from? and how does you overcloud deploy command look like? And some more details about your deployment (which nuage version) can be handy

jbemmel commented 4 years ago

I generate the templates under /home/stack and then overwrite using the git files. 5.4.1U12 but every version has the same issue

The other plugin files have the same relative path, absolute is wrong because it points to a different version of the same file

Overcloud deploy aborts with an error, it is unable to load from /usr/share

Sent from my iPhone

On Jul 23, 2020, at 3:44 PM, sjabasti notifications@github.com wrote:

 This does not seem right. Can you share the failure of your deployment? (when not applying this change) From which directory and user are you running the overcloud deploy from? And some more details about your deployment (which nuage version) can be handy

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

sjabasti commented 4 years ago

A few things:

I generate the templates under /home/stack and then overwrite using the git files. What do you mean with overwrite using the git files? (i am assuming you are running upgrade), relevant steps are

5.4.1U12 but every version has the same issue For 5.4.1U12 I hope you are checking out using the tag? For 5.4 releases we are using the branch 5.4/OSPD13

The other plugin files have the same relative path, absolute is wrong because it points to a different version of the same file Other plugin files usually links to this file ex

nuage-compute-vrs.yaml
....
  NeutronComputePluginNuage:
    type: neutron-compute-plugin-nuage.yaml

however this file links to a file (neutron-plugin-ml2.yaml) upstream as part of the openstack-tripleo-heat-templates rpm

neutron-plugin-ml2-nuage.yaml
....
  NeutronMl2Base:
    type: /usr/share/openstack-tripleo-heat-templates/puppet/services/neutron-plugin-ml2.yaml

it is unable to load from /usr/share Strange, is the yum package openstack-tripleo-heat-templates installed? ie does ls -la /usr/share/openstack-tripleo-heat-templates produce results? and does this file /usr/share/openstack-tripleo-heat-templates/puppet/services/neutron-plugin-ml2.yaml exist on your director?

Kind Regards Steven

jbemmel commented 4 years ago

Look at https://opendev.org/openstack/tripleo-heat-templates/src/commit/a462d796a7a1efe17c399e81395a22610b016952/puppet/services/neutron-plugin-ml2-nuage.yaml#L83 line 83 for example

I think what's special about this case is that the file is linking to itself. There are other places where the YAML refers to upstream files under /usr/share and that works fine: grep: ... templates/generated/docker/services/nova-compute-avrs.yaml: type: /usr/share/openstack-tripleo-heat-templates/docker/services/nova-compute.yaml

just this 1 line causes my deployment to break. I'm doing a fresh deployment of 5.4.1U12, checking out from git using that branch tag, generating the templates, and then overwriting the files with the git versions.

If I don't make this change, I get an error that it cannot load the URL http:///usr/share/.../neutron-plugin-ml2-nuage.yaml (even though the file does exist)

Regards, Jeroen

On Fri, Jul 24, 2020 at 3:47 AM sjabasti notifications@github.com wrote:

A few things:

I generate the templates under /home/stack and then overwrite using the git files. What do you mean with overwrite using the git files? (i am assuming you are running upgrade), relevant steps are

5.4.1U12 but every version has the same issue For 5.4.1U12 I hope you are checking out using the tag? For 5.4 releases we are using the branch 5.4/OSPD13

The other plugin files have the same relative path, absolute is wrong because it points to a different version of the same file Other plugin files usually links to this file ex

nuage-compute-vrs.yaml .... NeutronComputePluginNuage: type: neutron-compute-plugin-nuage.yaml

however this file links to a file (neutron-plugin-ml2.yaml) upstream as part of the openstack-tripleo-heat-templates rpm

neutron-plugin-ml2-nuage.yaml .... NeutronMl2Base: type: /usr/share/openstack-tripleo-heat-templates/puppet/services/neutron-plugin-ml2.yaml

/usr/share/openstack-tripleo-heat-templates/puppet/services/neutron-plugin-ml2.yaml

it is unable to load from /usr/share Strange is the yum package openstack-tripleo-heat-templates installed? ie does ls -la /usr/share/openstack-tripleo-heat-templates produce results?

Kind Regards Steven

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nuagenetworks/nuage-ospdirector/pull/130#issuecomment-663416670, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPQAC3VCNJ4YO5WWN6DBQLR5FDCLANCNFSM4PGCF3UQ .

jbemmel commented 4 years ago

[image: image.png] Sorry, it's not linking to itself - the path is different. But it fails. File permissions are the same as other files in that folder. With the relative path, it works.

Strange

Jeroen

On Fri, Jul 24, 2020 at 8:17 AM Jeroen van Bemmel jvb127@gmail.com wrote:

Look at https://opendev.org/openstack/tripleo-heat-templates/src/commit/a462d796a7a1efe17c399e81395a22610b016952/puppet/services/neutron-plugin-ml2-nuage.yaml#L83 line 83 for example

I think what's special about this case is that the file is linking to itself. There are other places where the YAML refers to upstream files under /usr/share and that works fine: grep: ... templates/generated/docker/services/nova-compute-avrs.yaml: type: /usr/share/openstack-tripleo-heat-templates/docker/services/nova-compute.yaml

just this 1 line causes my deployment to break. I'm doing a fresh deployment of 5.4.1U12, checking out from git using that branch tag, generating the templates, and then overwriting the files with the git versions.

If I don't make this change, I get an error that it cannot load the URL http:///usr/share/.../neutron-plugin-ml2-nuage.yaml (even though the file does exist)

Regards, Jeroen

On Fri, Jul 24, 2020 at 3:47 AM sjabasti notifications@github.com wrote:

A few things:

I generate the templates under /home/stack and then overwrite using the git files. What do you mean with overwrite using the git files? (i am assuming you are running upgrade), relevant steps are

5.4.1U12 but every version has the same issue For 5.4.1U12 I hope you are checking out using the tag? For 5.4 releases we are using the branch 5.4/OSPD13

The other plugin files have the same relative path, absolute is wrong because it points to a different version of the same file Other plugin files usually links to this file ex

nuage-compute-vrs.yaml .... NeutronComputePluginNuage: type: neutron-compute-plugin-nuage.yaml

however this file links to a file (neutron-plugin-ml2.yaml) upstream as part of the openstack-tripleo-heat-templates rpm

neutron-plugin-ml2-nuage.yaml .... NeutronMl2Base: type: /usr/share/openstack-tripleo-heat-templates/puppet/services/neutron-plugin-ml2.yaml

/usr/share/openstack-tripleo-heat-templates/puppet/services/neutron-plugin-ml2.yaml

it is unable to load from /usr/share Strange is the yum package openstack-tripleo-heat-templates installed? ie does ls -la /usr/share/openstack-tripleo-heat-templates produce results?

Kind Regards Steven

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nuagenetworks/nuage-ospdirector/pull/130#issuecomment-663416670, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPQAC3VCNJ4YO5WWN6DBQLR5FDCLANCNFSM4PGCF3UQ .

jbemmel commented 4 years ago

[image: image.png]

Here's what I do - the files under /home/stack/templates/generated are identical, and other files get loaded ok - just not this one

On Fri, Jul 24, 2020 at 8:27 AM Jeroen van Bemmel jvb127@gmail.com wrote:

[image: image.png] Sorry, it's not linking to itself - the path is different. But it fails. File permissions are the same as other files in that folder. With the relative path, it works.

Strange

Jeroen

On Fri, Jul 24, 2020 at 8:17 AM Jeroen van Bemmel jvb127@gmail.com wrote:

Look at https://opendev.org/openstack/tripleo-heat-templates/src/commit/a462d796a7a1efe17c399e81395a22610b016952/puppet/services/neutron-plugin-ml2-nuage.yaml#L83 line 83 for example

I think what's special about this case is that the file is linking to itself. There are other places where the YAML refers to upstream files under /usr/share and that works fine: grep: ... templates/generated/docker/services/nova-compute-avrs.yaml: type: /usr/share/openstack-tripleo-heat-templates/docker/services/nova-compute.yaml

just this 1 line causes my deployment to break. I'm doing a fresh deployment of 5.4.1U12, checking out from git using that branch tag, generating the templates, and then overwriting the files with the git versions.

If I don't make this change, I get an error that it cannot load the URL http:///usr/share/.../neutron-plugin-ml2-nuage.yaml (even though the file does exist)

Regards, Jeroen

On Fri, Jul 24, 2020 at 3:47 AM sjabasti notifications@github.com wrote:

A few things:

I generate the templates under /home/stack and then overwrite using the git files. What do you mean with overwrite using the git files? (i am assuming you are running upgrade), relevant steps are

5.4.1U12 but every version has the same issue For 5.4.1U12 I hope you are checking out using the tag? For 5.4 releases we are using the branch 5.4/OSPD13

The other plugin files have the same relative path, absolute is wrong because it points to a different version of the same file Other plugin files usually links to this file ex

nuage-compute-vrs.yaml .... NeutronComputePluginNuage: type: neutron-compute-plugin-nuage.yaml

however this file links to a file (neutron-plugin-ml2.yaml) upstream as part of the openstack-tripleo-heat-templates rpm

neutron-plugin-ml2-nuage.yaml .... NeutronMl2Base: type: /usr/share/openstack-tripleo-heat-templates/puppet/services/neutron-plugin-ml2.yaml

/usr/share/openstack-tripleo-heat-templates/puppet/services/neutron-plugin-ml2.yaml

it is unable to load from /usr/share Strange is the yum package openstack-tripleo-heat-templates installed? ie does ls -la /usr/share/openstack-tripleo-heat-templates produce results?

Kind Regards Steven

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nuagenetworks/nuage-ospdirector/pull/130#issuecomment-663416670, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPQAC3VCNJ4YO5WWN6DBQLR5FDCLANCNFSM4PGCF3UQ .

psairam commented 4 years ago

Hi Jeroen,

Why Absolute Path: In our documentation we always suggest users to place the nuage-tripleo-heat-templates in /home/stack/ path. Under the hood we also give users a flexibility of placing these template in any other locations as well (This is not officially recommended). Which is why we use absolute path for importing upstream openstack-tripleo-heat-templates only from /usr/share/openstack-tripleo-heat-templates/ instead of relative path.

It is strange that you are hitting issues with the path being absolute.

Btw, you are aware that we are no longer using nuage-heat-templates that are present in /usr/share/openstack-tripleo-heat-templates/. Which is why we are providing nuage-tripleo-heat-templates in our github.

Thanks, Sai