nuagenetworks / vis-graphs

Graphs visualisation framework
2 stars 15 forks source link

Multiple Heatmaps on a Dashboard not rendering intermittently #405

Closed chaitanyahalbe closed 3 years ago

chaitanyahalbe commented 4 years ago

I have multiple heatmaps on 1 dashboard in PR - https://github.com/nuagenetworks/vis-config/pull/202 (associated js-bambou PR - https://github.com/nuagenetworks/js-bambou/pull/174).

Problem #1: All 3 heatmaps on the dashboard should render at once after selecting proper filters. But only a few of them get rendered at once. Rarely, all 3 will get rendered. All the queries are returning data.

Problem #2: I have listeners in all the above 3 heatmaps, so that when a heatmap cell is clicked, a corresponding table is rendered showing details of that cell. But the problem is, upon clicking a cell on heatmap #1, all 3 tables for all the heatmaps get re-rendered even though I have different variable names, query-ids and visualizations for all 3 tables. Expected behaviour is, when a cell on heatmap #1 is clicked, only table #1 should get rendered/re-rendered.

chaitanyahalbe commented 4 years ago

@natabal @nxanil Created issue for multiple heatmaps.

natabal commented 4 years ago

@nxanil This issue is seen in other areas as well not just for this situation alone. See attached screenshots:

ike-tab-1 ike-tab-2

Screen Shot 2020-09-02 at 5 18 57 PM

Line Graph stack trace:

   at index.js:134
    at Array.map (<anonymous>)
    at LineGraph (index.js:128)
    at renderWithHooks (react-dom.development.js:15842)
    at mountIndeterminateComponent (react-dom.development.js:18162)
    at beginWork$1 (react-dom.development.js:19380)
    at HTMLUnknownElement.callCallback (react-dom.development.js:363)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:412)
    at invokeGuardedCallback (react-dom.development.js:466)
    at beginWork$$1 (react-dom.development.js:24597)
    at performUnitOfWork (react-dom.development.js:23529)
    at workLoopSync (react-dom.development.js:23507)
    at renderRoot (react-dom.development.js:23182)
    at runRootCallback (react-dom.development.js:22836)
    at react-dom.development.js:11907
    at unstable_runWithPriority (scheduler.development.js:676)
    at runWithPriority$2 (react-dom.development.js:11855)
    at flushSyncCallbackQueueImpl (react-dom.development.js:11902)
    at flushSyncCallbackQueue (react-dom.development.js:11890)
    at batchedUpdates$1 (react-dom.development.js:22935)
    at Object.notify (Subscription.js:19)
    at Subscription.notifyNestedSubs (Subscription.js:90)
    at Subscription.handleChangeWrapper (Subscription.js:95)
    at Object.dispatch (redux.js:222)
    at e (<anonymous>:1:40553)
    at middleware.js:36
    at index.js:11
    at index.js:41
    at dispatch (redux.js:640)
    at actions.js:324
killanch commented 3 years ago

@chaitanyahalbe could you pls check and confirm if this issue has been fixed in above commit?

chaitanyahalbe commented 3 years ago

@chaitanyahalbe could you pls check and confirm if this issue has been fixed in above commit?

@killanch This has already been verified. I'll close this.