search

nuagenetworks / vis-graphs

Graphs visualisation framework
2 stars 15 forks source link

FEC Explorer Table query issued twice #429

Open chaitanyahalbe opened 3 years ago

chaitanyahalbe commented 3 years ago

@nxanil There was an enhancement request for FEC Explorer where there will be 2 Tables on 1 dashboard which have the same query. The query is invoked twice for each table. For optimization purposes, in this scenario, the query, since same query is used here, should only be invoked once.

Screenshot: image

cc @killanch

nxanil commented 3 years ago

@chaitanyahalbe

I have checked at my end the query if invoke once for each visualization. Please check the below mention gif

tableQueryIssue

killanch commented 3 years ago

@nxanil your observation is correct. but the request is to optimize the current behavior. in case there are no visualization-specific filters and the visualizations use the same query (using dashboard level filters), can we avoid the duplication query? the query will be exactly the same

killanch commented 3 years ago

@sreddy80 any update on this? As per last comments in https://github.com/nuagenetworks/js-bambou/pull/182, you were to test the war file

sreddy80 commented 3 years ago

@killanch - I had verified the war file and spot checked Visualizations. As part of this verification, I had reported related issue on https://github.com/nuagenetworks/vis-graphs/issues/434. I need to bring up FEC setup for this, will check with Anamika on this.

killanch commented 3 years ago

@sreddy80 any update on this? pls let me know in case you need an updated war file

sreddy80 commented 3 years ago

@killanch - Did a sanity spot check on the graphs on this war file. Related Issue #434 is pending

nxanil commented 3 years ago

@chaitanyahalbe This issue is already created ISSUE:182 and has been resolved there. We can close this issue.