Closed nxjiten closed 4 years ago
Hi @nxjiten, I'm adding all the bugs down below in the comments one by one, please have a look at them.
@nxjiten Can you please fix this so we can merge this is master? Thanks
8 | const result = next(action), 9 | state = store.getState(); 10 | if (action.type === "@@router/LOCATION_CHANGE" && state.router && state.router.action !== 'pop' && state.router.location.query && state.router.location.pathname.indexOf('dashboards') !== -1) 11 | { View compiled (anonymous function) src/redux/middlewares.js:29 26 | } 27 | 28 | export const updateContextMiddleware = store => next => action => { 29 | const result = next(action), 30 | state = store.getState(); 31 | 32 | if (action.type === "@@router/LOCATION_CHANGE" && state.router) { View compiled ▶ 4 stack frames were collapsed. _callee$ src/services/servicemanager/redux/actions.js:183 180 | )) 181 | } 182 | 183 | dispatch(didReceiveResponse(requestID, data, forceCache)) | ^ 184 | 185 | return Promise.resolve(data); 186 | }, View compiled ▶ 5 stack frames were collapsed.
Rest all looks good.
@natabal @bmukheja
Fix "no dashboard" issue on toggle dashboards.
Also, I am not able to reproduce the console error, so it would be great if you will provide the table configuration and query response of the infraRegressResults dashboard so that I can test it at my end.
@nxjiten - Getting this error -
Hi @nxjiten - the issues with the dashboard have been resolved by changing to customTabify, we'll analyse what went wrong in the common tabification later, for now merging this PR as the above error has been resolved.
@natabal
Update the react version
16.6.3
and its dependent packages. Please have a look.