search

nuagenetworks / visualization-framework

Visualization Framework using ReactJS
BSD 3-Clause "New" or "Revised" License
7 stars 25 forks source link

[Enhancement]: Add support for custom filter #816

Open nxjiten opened 4 years ago

nxjiten commented 4 years ago

@natabal

Add support for custom filters #814.

natabal commented 4 years ago

@bmukheja Can you please test this?

bharat-mukheja commented 4 years ago

Hi @nxjiten , so there is a bug in this -

  1. When the close button on the filter is clicked, it strips off all the custom variables in the url and sets the url to the default for the dashboard
  2. The rest of the urls on the dashboard have already been created with those custom variables included, so when we switch the dashboard, it reapplies the custom Time filter. Please see the below video for the demo.

Screen Recording 2019-12-05 at 1.08.39 PM.mov.zip

nxjiten commented 4 years ago

@bmukheja I have fixed the issue mentioned in point 1 and working on point 2 issue which might take some time to fix.

bharat-mukheja commented 4 years ago

@nxjiten - That's okay, you can take your time. I haven't tested the new change yet, will test it today and comment.

nxjiten commented 4 years ago

@bmukheja, the second issue is also fixed. Please have a look and let me know.

bharat-mukheja commented 4 years ago

@nxjiten - This error is happening now

index.js:1437 Warning: Failed prop type: Invalid prop deleteIconStyle of type string supplied to Chip, expected object. in Chip (at Chips.js:18) in Chips (at FiltersToolBar/index.js:417) in li (at FiltersToolBar/index.js:416) in ul (at FiltersToolBar/index.js:430) in div (at FiltersToolBar/index.js:429) in FiltersToolBarView (created by Context.Consumer) in Connect(FiltersToolBarView) (at Dashboard/index.js:204) in div (at Dashboard/index.js:201) in DashboardView (created by Context.Consumer) in Connect(DashboardView) (created by Route) in Route (at App.js:18) in div (at AppContainer.js:62) in div (at AppContainer.js:59) in div (at AppContainer.js:79) in MuiThemeProvider (at AppContainer.js:78) in AppContainerView (created by Context.Consumer) in Connect(AppContainerView) (at App.js:16) in MuiThemeProvider (at App.js:15) in App (at src/index.js:15) in Router (created by ConnectedRouter) in ConnectedRouter (created by Context.Consumer) in ConnectedRouterWithContext (created by Context.Consumer) in Connect(ConnectedRouterWithContext) (at src/index.js:14) in Provider (at src/index.js:13)

nxjiten commented 4 years ago

@bmukheja I have fixed the warning in the Chip. Please have a look.

nxjiten commented 4 years ago

@natabal @bmukheja

Hi Bharat, As discussed with Natalia, please assign all the issues reported in visualization-framework.