Specs misalignment compared to the VSD API responses

[mfagadar]

Dear Nuage team,

I have found several misalignments between the spec files and the real API responses, as follows:

Nuage R4.0.8

• IngressAdvFwdEntryTemplate.spec : the stateful attribute is missing

Nuage R4.0.6 and later

• DemarcationService.spec : the priority attribute has the wrong type string instead of integer
• DucGroupBinding.spec : the id attribute seems to be unused and should be removed
• location.spec :
  • the uniqueScope property should be set to null instead of "no" for all attributes
  • the _maxvalue and _minvalue properties of the latitude and longitude attributes need to be in float format (i.e. 90.0 instead of 90)
• NsRedundantPort.spec :
  • the uniqueScope property should be set to null instead of "no" for all attributes
  • the _maxlength and _minlength properties of the useUserMnemonic attribute need to be null, since the attribute is of boolean type
• VsgRedundantPort.spec :
  • the uniqueScope property should be set to null instead of "no" for all attributes
  • the _maxlength and _minlength properties of the useUserMnemonic attribute need to be null, since the attribute is of boolean type

Can you please update the specs so that they reflect the real API responses? Our project relies on them for automatic code generation using the monolithe framework.

Thanks, Mihai

[pdellaert]

@mfagadar: Thank you so much for your clear analysis and help!

I'll take these remarks and create appropriate issues to track these (internally) and make sure with the next release, these should be covered/supported in here.

Some responses:

• IngressAdvFwdEntryTemplate: There is not stateful attribute in the API, stateful is not supported for redirection policies or forwarding policies. The UI does wrongfully send a stateful field when creating an IngressAdvFwdEntryTemplate, however, it is not returned by the API when fetching an IngressAdvFwdEntryTemplate

• Location: The uniqueScope field is set to null for all attributes already.

• NsRedundantPort: The uniqueScope field is set to null for all attributes already.

• VsgRedundantPort: The uniqueScope field is set to null for all attributes already.

BTW, i'm also very interested in what code you generate using the Monolithe framework. We should meet in Antwerp to see how we can better work together

[mfagadar]

@pdellaert Thank you for your answer and for the explanations. Looking forward to discuss with you in Antwerp.

Just for the record, we found a couple of extra modifications required in the R4.0.8 branch, as follows:

• enterprise.spec : the localAS attribute's maximum value constraint should be 64534
• me.spec : the child relation user should have create set to false

[mfagadar]

Dear Nuage Team, @pdellaert,

In respect to the R4.0.8 branch, currently in use by our project, we have found the following additional misalignments:

• enterprise : set "create": true for patnatpool under children
• ingressaclentrytemplate : set "required": false for domainName, enterpriseName and ACLTemplateName attributes
• performancemonitor : set "extends": ["@audited", "@base", "@metadata"] under model
• networkmacrogroup : set "relationship": "member" for the enterprisenetwork under children

Please include the above in the specs update.

All the best, Mihai

[pdellaert]

@mfagadar , thanks

• enterprise: this is fixed in 5.0
• ingressaclentrytemplate: These fields are not required when creating or updating an entry template, these are automatically filled in by the backend based on which ingressacltemplate you do the POST request
• performancemonitor Thanks, i'll have that checked (sometimes some of those are not needed, i'm pretty sure the metadata does not exist on a performance monitor)
• networkmacrogroup: That's a real bad one! Thanks for that, i'll look into that as well

[hellt]

afais, ingressaclentrytemplate has been fixed in v5.0.1 exactly with these params set to required: False

[mfagadar]

@pdellaert, another small one in R5.1.1 (there was an error in my post from May 8):

• enterprise.spec : the localAS attribute's maximum value constraint should be 65534 (not 64534)

[mfagadar]

Also for R5.1.1-U1:

• uplinkconnection.spec : the type of the uplinkID attribute should be integer instead of string

[pdellaert]

Going to close this for now, feel free to open a new issue if you find more required changes