nuagenetworks / vspk-python

A Python library for managing Nuage through its API
http://www.nuagenetworks.net
BSD 3-Clause "New" or "Revised" License
17 stars 19 forks source link

Should the "BEGIN_POLICY_CHANGES" job wait for all policies to be successfully copied from LIVE to DRAFT? #23

Closed hellt closed 7 years ago

hellt commented 7 years ago

Hi @pdellaert Is it possible that "BEGIN_POLICY_CHANGES" job returned SUCCESS status, but not all policies copied to DRAFT at that time?

A bug has been reported to me claiming that policy entry was non-existent in DRAFT mode right after the domain was put into policy editing mode? We will try to recreate this one with logs enabled, but I wanted to check upfront, maybe it is expected and some timeout should be put in place before trying to modify sec policy objects after moving into policy editing mode.

pdellaert commented 7 years ago

@hellt, a job with command BEGIN_POLICY_CHANGES should not return SUCCESS until all policies have been copied to DRAFT status. As long as copying is not finished, the job should remain in status RUNNING.

Somehow, i expect that whomever is filing the bug, is actually not waiting until the status is SUCCESS

hellt commented 7 years ago

Ok, understood. Will see if this issue will be reported ever again

On Tue, Nov 21, 2017 at 2:36 PM, Philippe Dellaert <notifications@github.com

wrote:

@hellt https://github.com/hellt, a job with command BEGIN_POLICY_CHANGES should not return SUCCESS until all policies have been copied to DRAFT status. As long as copying is not finished, the job should remain in status RUNNING.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nuagenetworks/vspk-python/issues/23#issuecomment-346000556, or mute the thread https://github.com/notifications/unsubscribe-auth/AFaq9QkhQgE0YzLiBciukPjqlJQ0-uZxks5s4rW6gaJpZM4Qkqgu .

pdellaert commented 7 years ago

Of course, if you actually see this is not the case, then we have a bug :), i just haven't heard of any case where this is not happening correctly, up until now.

hellt commented 7 years ago

most probably this issue had some other root causes. Will watch closely on this.

/close

On Tue, Nov 21, 2017 at 2:55 PM, Philippe Dellaert <notifications@github.com

wrote:

Of course, if you actually see this is not the case, then we have a bug :), i just haven't heard of any case where this is not happening correctly, up until now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nuagenetworks/vspk-python/issues/23#issuecomment-346004798, or mute the thread https://github.com/notifications/unsubscribe-auth/AFaq9Yyk_GYauoyE2yleHP2KHPaZ_ixPks5s4ro6gaJpZM4Qkqgu .